Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18330 )
Change subject: [tool] Fix pbc dump instance for -json/ -json_pretty ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18330/4/src/kudu/tools/tool_action_pbc.cc File src/kudu/tools/tool_action_pbc.cc: http://gerrit.cloudera.org:8080/#/c/18330/4/src/kudu/tools/tool_action_pbc.cc@210 PS4, Line 210: RETURN_NOT_OK(pb_reader.Dump(&stream, format, > In fact, I don't know all your ideas. I'm not sure that all pbc files have the 'uuid' field, so I think make decoding uuid optional may be appropriate. In your last patch a new input argument was added to 'ReadablePBContainerFile::Dump', I prefer not to decode a specific field in a generic function. Maybe do this in the dump tool? -- To view, visit http://gerrit.cloudera.org:8080/18330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21afb03d9b7b4b2d4ea5aaa642701451282bebf Gerrit-Change-Number: 18330 Gerrit-PatchSet: 7 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 15 Apr 2022 10:30:32 +0000 Gerrit-HasComments: Yes
