Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18402 )
Change subject: WIP [master] Add a rebalance request/response and provide a tool, refact master's rebalance ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/18402/7/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/18402/7/src/kudu/client/client-internal.cc@470 PS7, Line 470: // a list of potentially local hosts. It would be better to iterate over all of : // the local network adapters. See KUDU-327. : string hostname; : RETURN_NOT_OK(GetFQDN(&hostname)); : : // We don't want to consider 'localhost' to be local - otherwise if a misconfigured : // server reports its own name as localhost, all clients will hammer it. : if (hostname != "localhost" && hostname != "localhost.localdomain") { : local_host_names_.insert(hostname); : VLOG(1) << "Considering host " << hostname << " local"; : } : : vector<Sockaddr> addresses; : RETURN_NOT_OK_PREPEND(dns_resolver_->ResolveAddresses(HostPort(hostname, 0), : &addresses), : Substitute("Could not resolve local host name '$0'", hostname)); : : for (const Sockaddr& addr : addresses) { : // Similar to above, ignore local or wildcard addresses. : > Yes. It should be a synchronized task at master server side. I 'll think i To support the requirement, I add a timer at thread pool, the cr is: https://gerrit.cloudera.org/c/18447/. I'll use it to do synchronize task. http://gerrit.cloudera.org:8080/#/c/18402/7/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/18402/7/src/kudu/client/client.h@763 PS7, Line 763: /// : /// This method does an RPC to ensure that the table exists and : /// looks up its sc > I'm not very sure, other approch, I just use approch the same as CreateTabl Your idea is reasonable, I adopt the suggest and move it from client to CLI tool. -- To view, visit http://gerrit.cloudera.org:8080/18402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d506d877662c029a30dca9dd5029b9da4162946 Gerrit-Change-Number: 18402 Gerrit-PatchSet: 11 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 28 Apr 2022 03:01:38 +0000 Gerrit-HasComments: Yes
