Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18454 )
Change subject: [master] KUDU-3061 support auto rebalance tablet leaders across TServers ...................................................................... Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer-test.cc@57 PS1, Line 57: using std::map; > warning: using decl 'GetTableLocations' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer-test.cc@58 PS1, Line 58: using std::set; > warning: using decl 'ListTabletServers' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer-test.cc@59 PS1, Line 59: using std::string; > warning: using decl 'GetTableLocationsResponsePB' is unused [misc-unused-us Done http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer-test.cc@60 PS1, Line 60: using std::unique_ptr; > warning: using decl 'TSDescriptor' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer-test.cc@65 PS1, Line 65: DECLARE_int32(consensus_inject_latency_ms_in_notifications); > warning: using decl 'unordered_map' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer-test.cc@66 PS1, Line 66: DECLARE_int32(follower_unavailable_considered_failed_sec); > warning: using decl 'unordered_set' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer-test.cc@68 PS1, Line 68: DECLARE_int32(tablet_copy_download_file_inject_latency_ms); > warning: using decl 'Substitute' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer.cc@246 PS1, Line 246: vector<string> uuid_followers = follower_uuid_map[tablet_id]; > warning: do not use 'else' after 'continue' [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/18454/1/src/kudu/master/auto_leader_rebalancer.cc@274 PS1, Line 274: int32_t leader_count = pair.second; > warning: do not use 'else' after 'continue' [readability-else-after-return] Done -- To view, visit http://gerrit.cloudera.org:8080/18454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfb60d8759a93b6a19238637c27df4f6b1cac918 Gerrit-Change-Number: 18454 Gerrit-PatchSet: 3 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 05 May 2022 11:58:35 +0000 Gerrit-HasComments: Yes
