Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18454 )
Change subject: [master] KUDU-3061 support auto rebalance tablet leaders across TServers ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/18454/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18454/8//COMMIT_MSG@9 PS8, Line 9: tablets nit? tablet replicas http://gerrit.cloudera.org:8080/#/c/18454/8/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18454/8/src/kudu/master/catalog_manager.cc@3695 PS8, Line 3695: Status Always return OK, can we return void? Same to GetTableInfo above. http://gerrit.cloudera.org:8080/#/c/18454/8/src/kudu/master/catalog_manager.cc@3697 PS8, Line 3697: // leader_lock_.AssertAcquiredForReading(); Should AssertAcquired this lock? -- To view, visit http://gerrit.cloudera.org:8080/18454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfb60d8759a93b6a19238637c27df4f6b1cac918 Gerrit-Change-Number: 18454 Gerrit-PatchSet: 8 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 19 May 2022 02:04:51 +0000 Gerrit-HasComments: Yes
