Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18454 )
Change subject: [master] KUDU-3061 support auto rebalance tablet leaders across TServers ...................................................................... Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/18454/3/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/18454/3/src/kudu/master/auto_leader_rebalancer-test.cc@56 PS3, Line 56: DECLARE_int32(tablet_copy_download_file_inject_latency_ms); > warning: using decl 'RaftPeerPB' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/3/src/kudu/master/auto_leader_rebalancer-test.cc@57 PS3, Line 57: DECLARE_int32(tserver_unresponsive_timeout_ms); > warning: using decl 'map' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/3/src/kudu/master/auto_leader_rebalancer-test.cc@61 PS3, Line 61: DECLARE_uint32(auto_rebalancing_wait_for_replica_moves_seconds); > warning: using decl 'vector' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/4/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/18454/4/src/kudu/master/auto_leader_rebalancer-test.cc@55 PS4, Line 55: DECLARE_int32(raft_heartbeat_interval_ms); > warning: using decl 'RaftPeerPB' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/4/src/kudu/master/auto_leader_rebalancer-test.cc@56 PS4, Line 56: DECLARE_int32(tablet_copy_download_file_inject_latency_ms); > warning: using decl 'map' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/4/src/kudu/master/auto_leader_rebalancer-test.cc@60 PS4, Line 60: DECLARE_uint32(auto_rebalancing_max_moves_per_server); > warning: using decl 'vector' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/18454/3/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18454/3/src/kudu/master/auto_leader_rebalancer.cc@293 PS3, Line 293: if (!leader_transfer_tasks.empty()) { > warning: the 'empty' method should be used to check for emptiness instead o Done http://gerrit.cloudera.org:8080/#/c/18454/3/src/kudu/master/auto_leader_rebalancer.cc@293 PS3, Line 293: if (!leader_transfer_tasks.empty()) { > warning: the 'empty' method should be used to check for emptiness instead o Done http://gerrit.cloudera.org:8080/#/c/18454/4/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18454/4/src/kudu/master/auto_leader_rebalancer.cc@293 PS4, Line 293: if (!leader_transfer_tasks.empty()) { > warning: the 'empty' method should be used to check for emptiness instead o Done -- To view, visit http://gerrit.cloudera.org:8080/18454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfb60d8759a93b6a19238637c27df4f6b1cac918 Gerrit-Change-Number: 18454 Gerrit-PatchSet: 5 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 06 May 2022 05:12:50 +0000 Gerrit-HasComments: Yes
