Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18501 )

Change subject: [test] fix ASAN test failures in master-stress-test
......................................................................


Patch Set 2:

(2 comments)

> Patch Set 1:
>
> (2 comments)
>
> How often are these failure occasions? Does it happen once in a while, or 
> lets say 3-4 times out of 10 runs?

I think the failure doesn't occur very often in normal mode. But if we run the 
test in slow mode, sending more CreateTable/AlterTable/DeleteTable requests to 
the master, it often fails.

http://gerrit.cloudera.org:8080/#/c/18501/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18501/1/src/kudu/master/catalog_manager.cc@3840
PS1, Line 3840: // 'table' must remain valid for the lifetime of this class
> Nit: extra line
Done


http://gerrit.cloudera.org:8080/#/c/18501/1/src/kudu/master/catalog_manager.cc@3846
PS1, Line 3846:     : master_(master),
> Nit: spacing issue throughout the cosntructor
Done



--
To view, visit http://gerrit.cloudera.org:8080/18501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4eff45fbf05644362169485cd32678509eab1b07
Gerrit-Change-Number: 18501
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Khazar Mammadli <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Fri, 06 May 2022 12:28:11 +0000
Gerrit-HasComments: Yes

Reply via email to