Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18501 )
Change subject: [test] fix ASAN test failures in master-stress-test ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/18501/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18501/2/src/kudu/master/catalog_manager.cc@3840 PS2, Line 3840: Each created RetryingTSRpcTask should be added to TableI > Could you please add a comment to explain how it's guaranteed by the curren Done http://gerrit.cloudera.org:8080/#/c/18501/2/src/kudu/master/catalog_manager.cc@3845 PS2, Line 3845: Master* master, > Why to pass this as scoped_refptr if storing just the raw pointer? It woul Done -- To view, visit http://gerrit.cloudera.org:8080/18501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4eff45fbf05644362169485cd32678509eab1b07 Gerrit-Change-Number: 18501 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 07 May 2022 07:16:11 +0000 Gerrit-HasComments: Yes
