Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18501 )
Change subject: [test] fix ASAN test failures in master-stress-test ...................................................................... Patch Set 2: (2 comments) Thank you for taking a look at the master-stress test flakiness! http://gerrit.cloudera.org:8080/#/c/18501/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18501/2/src/kudu/master/catalog_manager.cc@3840 PS2, Line 3840: 'table' must remain valid for the lifetime of this class Could you please add a comment to explain how it's guaranteed by the current code? E.g., how to guarantee that each creted RetryingTSRpcTask is only passed to TableInfo::AddTask(), so it always end up in the TableInfo::pending_tasks_ of the corresponding instance? http://gerrit.cloudera.org:8080/#/c/18501/2/src/kudu/master/catalog_manager.cc@3845 PS2, Line 3845: const scoped_refptr<TableInfo>& table Why to pass this as scoped_refptr if storing just the raw pointer? It would help if you add a comment explaining the reason. Otherwise, maybe remove the scoped_refptr wrapper? -- To view, visit http://gerrit.cloudera.org:8080/18501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4eff45fbf05644362169485cd32678509eab1b07 Gerrit-Change-Number: 18501 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 06 May 2022 21:58:16 +0000 Gerrit-HasComments: Yes
