Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 )
Change subject: [tools] update schema if needed when rebuild master ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/kudu-admin-test.cc@3245 PS3, Line 3245: ScanTableToStrings(table.get(), &rows); nit: could we explicitly also check that the table has the right number of columns? http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@230 PS3, Line 230: table->mutable_metadata()->CommitMutation(); nit: maybe just put this after L246? http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@253 PS3, Line 253: nit: maybe log a message saying something like "ignoring mismatched schema since it has a lower version" or somesuch? -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 07 May 2022 07:07:00 +0000 Gerrit-HasComments: Yes
