Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 )
Change subject: [tools] update schema if needed when rebuild master ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/18496/4/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18496/4/src/kudu/tools/kudu-admin-test.cc@3219 PS4, Line 3219: to become he > nit: 'to become healthy' or 'to be in a good health' Done http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@230 PS3, Line 230: > I guess Andrew meant that it's enough to have this auto-commit guard just r CommitMutation will reset 'metadata' which is obtained by 'SysTablesEntryPB* metadata = &table->mutable_metadata()->mutable_dirty()->pb', but we will use 'metadata' to compare schemas after L246. Anyway, I adjusted the code to make it more readability. http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@253 PS3, Line 253: > +1 Done -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 10 May 2022 02:16:51 +0000 Gerrit-HasComments: Yes
