Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 )
Change subject: [tools] update schema if needed when rebuild master ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18496/4/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18496/4/src/kudu/tools/kudu-admin-test.cc@3219 PS4, Line 3219: to be health nit: 'to become healthy' or 'to be in a good health' http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@230 PS3, Line 230: // Return with non-OK status is not fatal, s > Since 'mutable_dirty' is obtained in L232, it is referenced and will be use I guess Andrew meant that it's enough to have this auto-commit guard just right before first return from this function -- having it anywhere before that doesn't change anything, right? -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 09 May 2022 14:48:13 +0000 Gerrit-HasComments: Yes
