Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18506 )
Change subject: [Tools] Set all masters/tservers flags in a cluster in batch mode ...................................................................... Patch Set 11: (4 comments) > Patch Set 10: -Code-Review > > (1 comment) http://gerrit.cloudera.org:8080/#/c/18506/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18506/10//COMMIT_MSG@7 PS10, Line 7: Tools] > nit: What about using 'tools' here ? Done http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc@8108 PS7, Line 8108: INSTANTIATE_TEST_SUITE_ > Done Done http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc@8109 PS7, Line 8109: estSetFl > Well, I meant modify the second parameter. To make test_suit_name/test_name Done http://gerrit.cloudera.org:8080/#/c/18506/10/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/18506/10/src/kudu/tools/tool_action_master.cc@160 PS10, Line 160: cons > nit: Maybe this could be const as well. Done -- To view, visit http://gerrit.cloudera.org:8080/18506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ce35389590c362d6167c677a7a3a28e08c040f Gerrit-Change-Number: 18506 Gerrit-PatchSet: 11 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Tue, 17 May 2022 06:51:23 +0000 Gerrit-HasComments: Yes
