Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18506 )
Change subject: [Config] Set all masters/tservers flags in a cluster in batch mode ...................................................................... Patch Set 9: Code-Review+1 (5 comments) Overall looks good, just a few nits. http://gerrit.cloudera.org:8080/#/c/18506/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18506/9//COMMIT_MSG@9 PS9, Line 9: once a time nit: once at a time http://gerrit.cloudera.org:8080/#/c/18506/9//COMMIT_MSG@12 PS9, Line 12: kudu master set_all_masters_flag <master_addresses> <flag> <value> : kudu tserver set_all_tservers_flag <master_addresses> <flag> <value> These seem to be outdated since the name for the sub-command has changed: please update. http://gerrit.cloudera.org:8080/#/c/18506/9/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18506/9/src/kudu/tools/kudu-tool-test.cc@8161 PS9, Line 8161: test for setting non-existed flag how about: A test for setting a non-existing flag. http://gerrit.cloudera.org:8080/#/c/18506/9/src/kudu/tools/kudu-tool-test.cc@8166 PS9, Line 8166: ASSERT_TRUE(s.IsRuntimeError()); nit: any specific message to expect from the tool here (it comes in the s.ToString() string)? http://gerrit.cloudera.org:8080/#/c/18506/9/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/18506/9/src/kudu/tools/tool_action_tserver.cc@142 PS9, Line 142: auto nit: could this be 'const' or even 'constexpr'? -- To view, visit http://gerrit.cloudera.org:8080/18506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ce35389590c362d6167c677a7a3a28e08c040f Gerrit-Change-Number: 18506 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 17 May 2022 03:23:29 +0000 Gerrit-HasComments: Yes
