Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18506 )
Change subject: [Config] Set all masters/tservers flags in a cluster in batch mode ...................................................................... Patch Set 10: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18506/7/src/kudu/tools/kudu-tool-test.cc@8109 PS7, Line 8109: sMaster) > Done Well, I meant modify the second parameter. To make test_suit_name/test_name/param_name clearer, we can rename the test like this: class SetFlagTest { }; INSTANTIATE_TEST_CASE_P(IsMaster, SetFlagTest, ::testing::Bool()); TEST_P(SetFlagTest, TestSetFlagForAll) { } http://gerrit.cloudera.org:8080/#/c/18506/10/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/18506/10/src/kudu/tools/tool_action_master.cc@160 PS10, Line 160: auto nit: Maybe this could be const as well. -- To view, visit http://gerrit.cloudera.org:8080/18506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ce35389590c362d6167c677a7a3a28e08c040f Gerrit-Change-Number: 18506 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 17 May 2022 05:07:53 +0000 Gerrit-HasComments: Yes
