Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18567 )
Change subject: [Catalog] Make Hostname case insensitive ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/18567/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18567/2//COMMIT_MSG@10 PS2, Line 10: Faft Raft http://gerrit.cloudera.org:8080/#/c/18567/2//COMMIT_MSG@15 PS2, Line 15: upper case nit: in upper case http://gerrit.cloudera.org:8080/#/c/18567/2/src/kudu/util/net/net_util-test.cc File src/kudu/util/net/net_util-test.cc: http://gerrit.cloudera.org:8080/#/c/18567/2/src/kudu/util/net/net_util-test.cc@322 PS2, Line 322: ASSERT_TRUE("localhost:12345" == hp1.ToStringWithLowcase()); nit: Use ASSERT_EQ instead, then you can get helpful message when assert failed. http://gerrit.cloudera.org:8080/#/c/18567/2/src/kudu/util/net/net_util-test.cc@324 PS2, Line 324: ASSERT_TRUE Same http://gerrit.cloudera.org:8080/#/c/18567/2/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/18567/2/src/kudu/util/net/net_util.cc@331 PS2, Line 331: Lowcase nit: LowerCase -- To view, visit http://gerrit.cloudera.org:8080/18567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If955e91a9e081dad7aebdcc497c413c8eb10eb4b Gerrit-Change-Number: 18567 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 29 May 2022 09:48:54 +0000 Gerrit-HasComments: Yes
