Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18567 )
Change subject: [Catalog] Make Hostname case insensitive ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18567/4/src/kudu/util/net/net_util.h File src/kudu/util/net/net_util.h: http://gerrit.cloudera.org:8080/#/c/18567/4/src/kudu/util/net/net_util.h@70 PS4, Line 70: std::string ToStringInLowercase() const; I think it would be risk to add another ToString*, how does everybody know where to use ToString() and where to use ToStringInLowercase() ? -- To view, visit http://gerrit.cloudera.org:8080/18567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If955e91a9e081dad7aebdcc497c413c8eb10eb4b Gerrit-Change-Number: 18567 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 07 Jun 2022 08:12:13 +0000 Gerrit-HasComments: Yes
