Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18567 )
Change subject: [Catalog] Make Hostname case insensitive ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/18567/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18567/7//COMMIT_MSG@9 PS7, Line 9: when starting firstly nit: at server startup http://gerrit.cloudera.org:8080/#/c/18567/7//COMMIT_MSG@9 PS7, Line 9: configure nit: config http://gerrit.cloudera.org:8080/#/c/18567/7//COMMIT_MSG@10 PS7, Line 10: configure nit: config http://gerrit.cloudera.org:8080/#/c/18567/7//COMMIT_MSG@11 PS7, Line 11: Therefore it will : be good to keep case insensitive for hostname. Maybe you mean DNS names are case insensitive? http://gerrit.cloudera.org:8080/#/c/18567/7//COMMIT_MSG@15 PS7, Line 15: when rewriting Raft configure, it uses /etc/hosts, which is in upper case. As far as I know, when using 'kudu local_replica cmeta rewrite_raft_config' tool to rewrite raft config, the raft peers and their hostnames are provided by users. Seems the tool doesn't use /etc/hosts to resolve addresses. http://gerrit.cloudera.org:8080/#/c/18567/7//COMMIT_MSG@15 PS7, Line 15: configure nit: config -- To view, visit http://gerrit.cloudera.org:8080/18567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If955e91a9e081dad7aebdcc497c413c8eb10eb4b Gerrit-Change-Number: 18567 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 16 Jun 2022 05:21:07 +0000 Gerrit-HasComments: Yes
