Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18503 )
Change subject: [KUDU-3367][compaction] Fix delta file with full of delete op can not be schedule to compact ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/18503/9/src/kudu/integration-tests/tablet_history_gc-itest.cc File src/kudu/integration-tests/tablet_history_gc-itest.cc: http://gerrit.cloudera.org:8080/#/c/18503/9/src/kudu/integration-tests/tablet_history_gc-itest.cc@615 PS9, Line 615: FLAGS_rowset_metadata_store_keys = true; Is it related to this patch? http://gerrit.cloudera.org:8080/#/c/18503/9/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/18503/9/src/kudu/tablet/delta_tracker.cc@936 PS9, Line 936: if ((column_ids_for_compact.size() == last_ids_size) Could you explain how does it resolve this problem? http://gerrit.cloudera.org:8080/#/c/18503/9/src/kudu/tablet/delta_tracker.cc@943 PS9, Line 943: std::vector<ColumnId> 'const auto&' is OK? -- To view, visit http://gerrit.cloudera.org:8080/18503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b26737dffecc17688b42188da959b2ba16351ed Gerrit-Change-Number: 18503 Gerrit-PatchSet: 9 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 01 Jun 2022 10:36:46 +0000 Gerrit-HasComments: Yes
