Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18503 )
Change subject: [KUDU-3367][compaction] Fix delta file with full of delete op can not be schedule to compact ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/18503/11/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/18503/11/src/kudu/tablet/delta_tracker.cc@60 PS11, Line 60: all_delete_op_delta_file_outdated_for_compact_s > nit: all_delete_op_delta_file_outdated_for_compact_sec In fact you can use tablet_history_max_age_sec instead of introducing a new flag. http://gerrit.cloudera.org:8080/#/c/18503/11/src/kudu/tablet/delta_tracker.cc@972 PS11, Line 972: MonoDelta elapsed = MonoTime::Now() - last_update_time_; > Since the last_update_time_ is for the whole DeltaTracker, I'm afraid it do Sorry, ignore this. -- To view, visit http://gerrit.cloudera.org:8080/18503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b26737dffecc17688b42188da959b2ba16351ed Gerrit-Change-Number: 18503 Gerrit-PatchSet: 11 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 28 Nov 2022 05:12:09 +0000 Gerrit-HasComments: Yes
