Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18503 )
Change subject: [KUDU-3367][compaction] Fix delta file with full of delete op can not be schedule to compact ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/18503/11/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/18503/11/src/kudu/tablet/delta_tracker.cc@60 PS11, Line 60: all_delete_op_delta_file_outdated_for_compact_s nit: all_delete_op_delta_file_outdated_for_compact_sec http://gerrit.cloudera.org:8080/#/c/18503/11/src/kudu/tablet/delta_tracker.cc@439 PS11, Line 439: return Status::OK(); There are some cases that the compaction not actually run, but you still update 'last_update_time_', would it cause unexpect result? http://gerrit.cloudera.org:8080/#/c/18503/11/src/kudu/tablet/delta_tracker.cc@973 PS11, Line 973: const auto kOutdatedInterval = MonoDelta::FromSeconds( : FLAGS_all_delete_op_delta_file_outdated_for_compact_s); : bool is_outdated = elapsed > kOutdatedInterval; : if (all_delete_op_delta_store_cnt > FLAGS_all_delete_op_delta_file_cnt_for_compact : && is_outdated) { nit: these code can be simplyfied. http://gerrit.cloudera.org:8080/#/c/18503/11/src/kudu/tablet/delta_tracker.cc@980 PS11, Line 980: for (const auto& id : schema_column_ids) { : column_ids_for_compact.insert(id); : } nit: how about column_ids_for_compact.insert(column_ids_for_compact.begin(), column_ids_for_compact.end()) ? -- To view, visit http://gerrit.cloudera.org:8080/18503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b26737dffecc17688b42188da959b2ba16351ed Gerrit-Change-Number: 18503 Gerrit-PatchSet: 11 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 24 Jun 2022 10:57:31 +0000 Gerrit-HasComments: Yes
