Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18582 )
Change subject: KUDU-2671 refactor PartitionSchema::CreatePartitions() ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18582/4/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/18582/4/src/kudu/common/partition-test.cc@1349 PS4, Line 1349: EXPECT_EQ(string("", 0), partitions[10].end().ToString()); > warning: constructor creating an empty string [bugprone-string-constructor] Done -- To view, visit http://gerrit.cloudera.org:8080/18582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bac1f8ee349577e2f912530a28776415ed0a5b0 Gerrit-Change-Number: 18582 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 03 Jun 2022 19:08:34 +0000 Gerrit-HasComments: Yes
