Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18582 )
Change subject: KUDU-2671 refactor PartitionSchema::CreatePartitions() ...................................................................... Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18582/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18582/5/src/kudu/master/catalog_manager.cc@1931 PS5, Line 1931: const auto ranges_with_hash_schemas_size = : partition_schema.ranges_with_hash_schemas().size() > It's not used outside of the condition, so I wanted to keep it only in the Ack -- To view, visit http://gerrit.cloudera.org:8080/18582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bac1f8ee349577e2f912530a28776415ed0a5b0 Gerrit-Change-Number: 18582 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 07 Jun 2022 20:34:14 +0000 Gerrit-HasComments: Yes
