Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18582 )
Change subject: KUDU-2671 refactor PartitionSchema::CreatePartitions() ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18582/5/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/18582/5/src/kudu/common/partition.h@289 PS5, Line 289: range nit: "range partition" might be a bit clearer. http://gerrit.cloudera.org:8080/#/c/18582/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18582/5/src/kudu/master/catalog_manager.cc@2670 PS5, Line 2670: RETURN_NOT_OK(partition_schema.CreatePartitions( : {}, {{ *ops[0].split_row, *ops[1].split_row }}, schema, &partitions)); > How does adding a range with a custom hash schema work now? It's unclear ho +1 Maybe pass the AlterTableRequestPB to CatalogManager::ApplyAlterPartitioningSteps and set the ranges_with_hash_schemas_ -- To view, visit http://gerrit.cloudera.org:8080/18582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bac1f8ee349577e2f912530a28776415ed0a5b0 Gerrit-Change-Number: 18582 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 04 Jun 2022 01:11:47 +0000 Gerrit-HasComments: Yes
