Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18642 )
Change subject: KUDU-2671 update partition schema in catalog when dropping range ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/18642/1/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/18642/1/src/kudu/common/partition-test.cc@1898 PS1, Line 1898: ASSERT_EQ(0, ps.ranges_with_hash_schemas().size()); > nit: check helper map size before and after as well. Done http://gerrit.cloudera.org:8080/#/c/18642/1/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18642/1/src/kudu/common/partition.cc@1738 PS1, Line 1738: continue; > I know there's a check in catalog manager but do you think it's worth addin Done I added DCHECK_EQ() to compare the size of the original and the updated array. http://gerrit.cloudera.org:8080/#/c/18642/1/src/kudu/common/partition.cc@1744 PS1, Line 1744: updated_array.size() > Shouldn't this be size as well? updated_array.size() will be (size - 1) ass Good catch -- this seems to be a bug introduced while I worked on a couple revisions of this code. There should be no 'continue' condition while iterating through the 'updated_array' container, of course. -- To view, visit http://gerrit.cloudera.org:8080/18642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib78afdd1a358751dca43f564c5d8e69191f165d4 Gerrit-Change-Number: 18642 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 22 Jun 2022 18:53:59 +0000 Gerrit-HasComments: Yes
