Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18642 )
Change subject: KUDU-2671 update partition schema in catalog when dropping range ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18642/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18642/1/src/kudu/master/catalog_manager.cc@2699 PS1, Line 2699: } else if (step.type() == AlterTableRequestPB::DROP_RANGE_PARTITION) { > To summarize, for adding a range you just updated the partition schema prot Yes, that's right: removing one of the repeated fields in a protobuf structure would be not very performant. Probably, as a next step we can refactor the code and apply a similar approach for the ADD_RANGE_PARTITION control path, adding PartitionSchema::AddRange() method, and then we could remove PartitionSchema::CreatePartitionsForRange() method and use PartitionSchema::CreatePartitions() instead. I guess we can do that in a separate changelist. -- To view, visit http://gerrit.cloudera.org:8080/18642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib78afdd1a358751dca43f564c5d8e69191f165d4 Gerrit-Change-Number: 18642 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 22 Jun 2022 19:03:37 +0000 Gerrit-HasComments: Yes
