Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18642 )
Change subject: KUDU-2671 update partition schema in catalog when dropping range ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18642/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18642/2/src/kudu/common/partition.cc@1746 PS2, Line 1746: for (size_t idx = 0; idx < updated_array.size(); ++idx) { Can we combine the two for loops since this is just essentially copying over the contents of updated_array to updated_mapping? http://gerrit.cloudera.org:8080/#/c/18642/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18642/1/src/kudu/master/catalog_manager.cc@2699 PS1, Line 2699: } else if (step.type() == AlterTableRequestPB::DROP_RANGE_PARTITION) { > Yes, that's right: removing one of the repeated fields in a protobuf struct Ack -- To view, visit http://gerrit.cloudera.org:8080/18642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib78afdd1a358751dca43f564c5d8e69191f165d4 Gerrit-Change-Number: 18642 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 22 Jun 2022 19:48:04 +0000 Gerrit-HasComments: Yes
