Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17879 )
Change subject: KUDU-2671: Follow up pruning patch. ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/17879/9/src/kudu/common/partition_pruner.h File src/kudu/common/partition_pruner.h: http://gerrit.cloudera.org:8080/#/c/17879/9/src/kudu/common/partition_pruner.h@108 PS9, Line 108: range_bounds_to_partition_key_ranges_ It's not a part of this particular changelist, but looking at this from the conceptual point, I guess this might be flatten into a one-dimensional array or ranges (something similar to 'partition_key_ranges_' as it used to be prior to bca9d73f90d02209e67615c140cd9c5311a6d8fb changelist). I think that should simplify the logic of advancing through the partition key subspace defined by the PartitionPruner for a scan upon subsequent calls of the RemovePartitionKeyRange() method. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/17879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a1bf5344c0ef856072d3ed102714dce5ba21060 Gerrit-Change-Number: 17879 Gerrit-PatchSet: 9 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 25 Jun 2022 00:12:24 +0000 Gerrit-HasComments: Yes
