Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17879 )
Change subject: KUDU-2671: Follow up pruning patch. ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/17879/14/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/17879/14/src/kudu/common/partition_pruner.cc@569 PS14, Line 569: partition_key_ranges_.rbegin() This simply leads to replacing last elements of partition_key_ranges_. Not sure that's exactly what we need here. I guess it should be back_inserter(partition_key_ranges_) or it's necessary to pre-allocate additional elements in partition_key_ranges_ otherwise if using this sort of approach. -- To view, visit http://gerrit.cloudera.org:8080/17879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a1bf5344c0ef856072d3ed102714dce5ba21060 Gerrit-Change-Number: 17879 Gerrit-PatchSet: 14 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 03 Jul 2022 22:15:38 +0000 Gerrit-HasComments: Yes
