Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17879 )
Change subject: KUDU-2671: Follow up pruning patch. ...................................................................... KUDU-2671: Follow up pruning patch. This patch flattens the result set of the pruner into a one dimensional container. The new container only contains the partition key ranges and no longer stores the range bounds. Currently, full scans using KuduScanner with no predicates are functional. Scans with range predicates are also functional on tables with covering ranges as well as on tables with non covering ranges. There are a few commented out test cases within flex_partitioning_client-test. These test cases involve a scan with range predicates that are both out of bounds. They fail because the non covering range case is triggered in scanner_internal and we return early from this function before the proxy_ is set. Check(proxy_) is where the tests fails in KuduScanner::NextBatch within client.cc. Using KuduScanTokens to scan tables with range specific hash schemas is not yet compatible. A follow up patch should address this deficiency. The scan token tests with custom hash schemas are failing when verifying the tablet info. It seems that the data_ field of the KuduTablets isn't set. Change-Id: I3a1bf5344c0ef856072d3ed102714dce5ba21060 Reviewed-on: http://gerrit.cloudera.org:8080/17879 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/client/client.h M src/kudu/client/flex_partitioning_client-test.cc M src/kudu/client/scan_token-internal.cc M src/kudu/client/scan_token-test.cc M src/kudu/client/scanner-internal.cc M src/kudu/common/partition_pruner-test.cc M src/kudu/common/partition_pruner.cc M src/kudu/common/partition_pruner.h 8 files changed, 582 insertions(+), 122 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3a1bf5344c0ef856072d3ed102714dce5ba21060 Gerrit-Change-Number: 17879 Gerrit-PatchSet: 15 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241)
