Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18642 )
Change subject: KUDU-2671 update partition schema in catalog when dropping range ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18642/3/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/18642/3/src/kudu/common/partition-test.cc@1902 PS3, Line 1902: RowOperationsPBEncoder encoder(range->mutable_range_bounds()); > nit: one more time or once more Done http://gerrit.cloudera.org:8080/#/c/18642/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18642/5/src/kudu/master/catalog_manager.cc@2645 PS5, Line 2645: step.type() == AlterTableRequestPB::ADD_RANGE_PARTITION > what is the purpose of this? Ah, that's to make sure we don't store information on other than ranges with custom hash schemas in PartitionSchemaPB persisted in the system catalog. I can remove this now since I refactored what information is stored in PartitionSchema (the counterpart for PartitionSchemaPB). -- To view, visit http://gerrit.cloudera.org:8080/18642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib78afdd1a358751dca43f564c5d8e69191f165d4 Gerrit-Change-Number: 18642 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Sat, 25 Jun 2022 00:37:11 +0000 Gerrit-HasComments: Yes
