Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18567 )
Change subject: [Catalog] Make DNS name of Kudu master case insensitive ...................................................................... Patch Set 9: (2 comments) > Patch Set 8: > > (2 comments) http://gerrit.cloudera.org:8080/#/c/18567/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18567/8//COMMIT_MSG@16 PS8, Line 16: ma > nit: maybe Done http://gerrit.cloudera.org:8080/#/c/18567/8/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/18567/8/src/kudu/master/sys_catalog.cc@225 PS8, Line 225: string raft_master_addr_str = raft_master_addr.ToString(); : ToLowerCase(&raft_master_addr_str); : string master_addr_str = master_addr.ToString(); : ToLowerCase(&master_addr_str); : if (!iequals(raft_master_addr_str, master_addr > nit: how about use kudu::iequals(...) instead? Done -- To view, visit http://gerrit.cloudera.org:8080/18567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If955e91a9e081dad7aebdcc497c413c8eb10eb4b Gerrit-Change-Number: 18567 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 27 Jun 2022 02:51:51 +0000 Gerrit-HasComments: Yes
