Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18567 )

Change subject: [Catalog] Make DNS name of Kudu master case insensitive
......................................................................


Patch Set 10:

(1 comment)

> Patch Set 9:
>
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/18567/9/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/18567/9/src/kudu/master/sys_catalog.cc@225
PS9, Line 225: string raft_master_addr_str = raft_master_addr.ToString();
             :       string master_addr_str = master_addr.ToString();
             :       if (!iequals(raft_master_addr_str, master_addr_str)) {
             :         return Status::InvalidArgume
> No need to transfer case if you use iequals.
Done



--
To view, visit http://gerrit.cloudera.org:8080/18567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If955e91a9e081dad7aebdcc497c413c8eb10eb4b
Gerrit-Change-Number: 18567
Gerrit-PatchSet: 10
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Mon, 27 Jun 2022 03:18:26 +0000
Gerrit-HasComments: Yes

Reply via email to