Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18663 )
Change subject: WIP [c++ client] KUDU-2671 Custom hash schema alter table support ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/18663/1/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18663/1/src/kudu/client/client.cc@1542 PS1, Line 1542: dimension_label > nit here and below: is it possible get rid of the variable and call new Kud Done http://gerrit.cloudera.org:8080/#/c/18663/1/src/kudu/client/flex_partitioning_client-test.cc File src/kudu/client/flex_partitioning_client-test.cc: http://gerrit.cloudera.org:8080/#/c/18663/1/src/kudu/client/flex_partitioning_client-test.cc@275 PS1, Line 275: owing part > It would be more convenient to have LESS here: by the common convention at Done http://gerrit.cloudera.org:8080/#/c/18663/1/src/kudu/client/flex_partitioning_client-test.cc@1109 PS1, Line 1109: ASSERT_OK(lower_drop->SetInt32(kKeyColum > nit: probably it makes sense to check the count right after creating the ta Done http://gerrit.cloudera.org:8080/#/c/18663/1/src/kudu/client/table_alterer-internal.h File src/kudu/client/table_alterer-internal.h: http://gerrit.cloudera.org:8080/#/c/18663/1/src/kudu/client/table_alterer-internal.h@66 PS1, Line 66: y set when the > This is a raw pointer. Who is the owner? If that's this class, it must de Done -- To view, visit http://gerrit.cloudera.org:8080/18663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4b1e306cca096d9479f06669cc22cc40d77fb42 Gerrit-Change-Number: 18663 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 29 Jun 2022 02:06:41 +0000 Gerrit-HasComments: Yes
