Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18663 )
Change subject: WIP [c++ client] KUDU-2671 Custom hash schema alter table support ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18663/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/18663/2/src/kudu/client/client.h@1979 PS2, Line 1979: const std::string& dimension_label); I'm not sure we want to support dimension labels for this right out of the box. Per https://issues.apache.org/jira/browse/KUDU-2974, the dimension labels look obsolete since the rebalancer tool now supports range-aware rebalancing (you can see how the range-related hotspotting transformed into the idea of dimension label of tablets at https://issues.apache.org/jira/browse/KUDU-2823). If there are parties interested in this feature, I'd suggest to add support for dimension labels later on. The rationale is simple -- it's always easy to add more API calls than remove already published ones since we do honor backward-compatibility. http://gerrit.cloudera.org:8080/#/c/18663/2/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18663/2/src/kudu/client/client.cc@1504 PS2, Line 1504: nit: an extra line -- To view, visit http://gerrit.cloudera.org:8080/18663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4b1e306cca096d9479f06669cc22cc40d77fb42 Gerrit-Change-Number: 18663 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 29 Jun 2022 19:03:06 +0000 Gerrit-HasComments: Yes
