Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18663 )
Change subject: WIP [c++ client] KUDU-2671 Custom hash schema alter table support ...................................................................... Patch Set 4: > Uploaded patch set 4. It seems due to some typedef movements IWYU points to some nits: >>> Fixing #includes in >>> '/home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/table_alterer-internal.h' @@ -24,7 +24,6 @@ #include <vector> #include "kudu/client/client.h" -#include "kudu/client/table_creator-internal.h" #include "kudu/gutil/macros.h" #include "kudu/master/master.pb.h" #include "kudu/util/monotime.h" >>> Fixing #includes in >>> '/home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/table_alterer-internal.cc' @@ -28,6 +28,7 @@ #include "kudu/client/schema-internal.h" #include "kudu/client/schema.h" +#include "kudu/client/table_creator-internal.h" #include "kudu/common/common.pb.h" #include "kudu/common/row_operations.h" #include "kudu/common/row_operations.pb.h" IWYU would have edited 2 files on your behalf. -- To view, visit http://gerrit.cloudera.org:8080/18663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4b1e306cca096d9479f06669cc22cc40d77fb42 Gerrit-Change-Number: 18663 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 30 Jun 2022 04:52:39 +0000 Gerrit-HasComments: No
