Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18674 )
Change subject: [threadpool] Fix scheduler thread a coredump bug ...................................................................... Patch Set 43: (2 comments) http://gerrit.cloudera.org:8080/#/c/18674/43/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/18674/43/src/kudu/util/threadpool.h@168 PS43, Line 168: token->Schedule What about handling the return status? http://gerrit.cloudera.org:8080/#/c/18674/43/src/kudu/util/threadpool.h@172 PS43, Line 172: // ThreadPoolToken* t = token.release(); // delete the token(s). : // delete t; : // ThreadPool* pool = scheduler_pool.release(); // release scheduler_pool. : // delete pool; Why is this necessary when both 'token' and 'scheduler_pool' are unique_ptr and take care of de-allocating/deleting the underlying pointers? -- To view, visit http://gerrit.cloudera.org:8080/18674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5bc5511a745f3dc12dfe1a6a1813ece41ccc2a8 Gerrit-Change-Number: 18674 Gerrit-PatchSet: 43 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 23 Jul 2022 06:09:50 +0000 Gerrit-HasComments: Yes
