Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18674 )
Change subject: [threadpool] Fix scheduler thread a coredump bug ...................................................................... Patch Set 45: (2 comments) DONE. Thank you very much. It's very kind of you. I am very sorry for my bad English. http://gerrit.cloudera.org:8080/#/c/18674/44/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/18674/44/src/kudu/util/threadpool.h@170 PS44, Line 170: The order of Shutdown and Release should adhere to the notice above, for example: > how about: Get it, You are very kind. http://gerrit.cloudera.org:8080/#/c/18674/44/src/kudu/util/threadpool.h@172 PS44, Line 172: The 'token' and 'scheduler_pool' will be released automatically in reverse order of : // // their declaration: that's the pr > how about: OK. -- To view, visit http://gerrit.cloudera.org:8080/18674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5bc5511a745f3dc12dfe1a6a1813ece41ccc2a8 Gerrit-Change-Number: 18674 Gerrit-PatchSet: 45 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 26 Jul 2022 08:24:11 +0000 Gerrit-HasComments: Yes
