Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18674 )
Change subject: [threadpool] Fix scheduler thread a coredump bug ...................................................................... Patch Set 44: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/18674/44/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/18674/44/src/kudu/util/threadpool.h@170 PS44, Line 170: The order of Shutdown and Release should satisfy the declaration above, For example: how about: The order of Shutdown and Release should adhere to the notice above, for example: http://gerrit.cloudera.org:8080/#/c/18674/44/src/kudu/util/threadpool.h@172 PS44, Line 172: The token and scheduler_pool will be released automatically, its deleted order is : // // satisfied the declaration above. how about: The 'token' and 'scheduler_pool' will be released automatically in reverse order of their declaration: that's the proper sequence as prescribed above. http://gerrit.cloudera.org:8080/#/c/18674/43/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/18674/43/src/kudu/util/threadpool.h@168 PS43, Line 168: RETURN_NOT_OK(t > DONE Thank you! http://gerrit.cloudera.org:8080/#/c/18674/43/src/kudu/util/threadpool.h@172 PS43, Line 172: // // The token and scheduler_pool will be released automatically, its deleted order is : // // satisfied the declaration above. : // : class SchedulerTh > Yes. In the example the automatically release order is ok and no need speci Thanks! -- To view, visit http://gerrit.cloudera.org:8080/18674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5bc5511a745f3dc12dfe1a6a1813ece41ccc2a8 Gerrit-Change-Number: 18674 Gerrit-PatchSet: 44 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 26 Jul 2022 06:06:46 +0000 Gerrit-HasComments: Yes
