Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18794 )
Change subject: [tools] KUDU-2671 Update the kudu table describe tool ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/18794/2/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18794/2/src/kudu/tools/kudu-admin-test.cc@2103 PS2, Line 2103: const string nit: could be a compile-time constant, i.e. constexpr const char* const kTableName http://gerrit.cloudera.org:8080/#/c/18794/2/src/kudu/tools/kudu-admin-test.cc@2113 PS2, Line 2113: _p1 nit for here and below: since those are scope-specific variables, you can drop the suffix here and in the scope below for easier readability http://gerrit.cloudera.org:8080/#/c/18794/2/src/kudu/tools/kudu-admin-test.cc@2126 PS2, Line 2126: nit for here and below: wrong indent http://gerrit.cloudera.org:8080/#/c/18794/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18794/1/src/kudu/tools/tool_action_table.cc@291 PS1, Line 291: const char* const kReplicationFactorArg = "replication_factor"; > No, it shouldn't be there. Thanks for catching it. I guess we should thank the TidyBot for catching this :) -- To view, visit http://gerrit.cloudera.org:8080/18794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fa2eb965051a5f63d1c482e6fd43ff654ec6364 Gerrit-Change-Number: 18794 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 28 Jul 2022 00:01:36 +0000 Gerrit-HasComments: Yes
