Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18794 )

Change subject: [tools] KUDU-2671 Update the kudu table describe tool
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18794/3/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/18794/3/src/kudu/tools/tool_action_table.cc@438
PS3, Line 438:         
partition_schema.RangeWithCustomHashPartitionDebugString(partition.begin().range_key(),
             :                                                                  
partition.end().range_key(),
             :                                                                  
schema_internal);
After comparing this to the output in the UI of the embedded web server, I 
thought that an alternative way of doing this might be printing out hash schema 
information on every range if some extra flag is provided.

Just trying to find the best path forward.    What do you think?

This also looks good enough to me, though.



--
To view, visit http://gerrit.cloudera.org:8080/18794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fa2eb965051a5f63d1c482e6fd43ff654ec6364
Gerrit-Change-Number: 18794
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 28 Jul 2022 18:54:48 +0000
Gerrit-HasComments: Yes

Reply via email to