Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18794 )
Change subject: [tools] KUDU-2671 Update the kudu table describe tool ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18794/2/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18794/2/src/kudu/tools/kudu-admin-test.cc@2103 PS2, Line 2103: constexpr co > nit: could be a compile-time constant, i.e. Done http://gerrit.cloudera.org:8080/#/c/18794/2/src/kudu/tools/kudu-admin-test.cc@2113 PS2, Line 2113: (sc > nit for here and below: since those are scope-specific variables, you can d Done http://gerrit.cloudera.org:8080/#/c/18794/2/src/kudu/tools/kudu-admin-test.cc@2126 PS2, Line 2126: CHEC > nit for here and below: wrong indent Done -- To view, visit http://gerrit.cloudera.org:8080/18794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fa2eb965051a5f63d1c482e6fd43ff654ec6364 Gerrit-Change-Number: 18794 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 28 Jul 2022 15:39:23 +0000 Gerrit-HasComments: Yes
