Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18822 )

Change subject: KUDU-3386 Update macOS docs for ARM
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG@9
PS1, Line 9: ]
as this commit is merged already, it's better to use the commit hash instead of 
the gerrit link.


http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG@13
PS1, Line 13: Finally
nit: comma


http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@550
PS1, Line 550: macs
nit: Macs, and maybe mention Apple M chips for the first time in parentheses?


http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@609
PS1, Line 609: .ARM macs
is this only for ARM Macs? Shouldn't this be done on Intel Macs as well?



--
To view, visit http://gerrit.cloudera.org:8080/18822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c
Gerrit-Change-Number: 18822
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Mon, 08 Aug 2022 09:17:44 +0000
Gerrit-HasComments: Yes

Reply via email to