Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/18822/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18822/2//COMMIT_MSG@10 PS2, Line 10: As the introductory line says, we now support ARM. Added a li > nit: Maybe rephrase to "As the introductory line says, we now support ARM. Done http://gerrit.cloudera.org:8080/#/c/18822/2//COMMIT_MSG@12 PS2, Line 12: The range of ARM Kudu compatible Xcode versions are : outlined. Finally, > nit: rephrase to "The range of ARM Kudu compatible Xcode versions are outli Done http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@609 PS1, Line 609: .ARM Macs > I always had this in my bash_profile on my Intel Mac. I don't remember what Should I then move this out of the "ARM" label? Could someone please, with an Intel Mac, check a thirdparty build for JWT, whether the openssl pkg config export is needed? http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc@568 PS2, Line 568: Apple introduced support for Apple silicon in Xcode version : link:https://developer.apple.com/documentation/xcode-release-notes/xcode-12_2-release-notes[12.2]. : To build Kudu on ARM-based Macs (Apple M chips), use > How about rephrasing this to be more specific what 'use' means and Basically Xcode version 13.2.1 inclusive, can be used to build all thirdparty libs successfully. Going above 13.2.1, the first issue I encountered, is that gmock breaks. I created a jira for this issue: KUDU-3391. Maybe thats all, maybe other issues come up. As of right now Xcode 13.2.1 inclusive is the upper limit, which works out of the box. As last week's investigations show, this counts for Intel and ARM based Macs as well. Included another sentence outside of the "ARM" label to highlight the max Xcode version for Intel based Macs. http://gerrit.cloudera.org:8080/#/c/18822/2/docs/installation.adoc@611 PS2, Line 611: , > It would be great to clarify why this is necessary. Done -- To view, visit http://gerrit.cloudera.org:8080/18822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c Gerrit-Change-Number: 18822 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 24 Aug 2022 19:42:28 +0000 Gerrit-HasComments: Yes
