Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/18822 )
Change subject: KUDU-3386 Update macOS docs for ARM ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG@9 PS1, Line 9: ] > as this commit is merged already, it's better to use the commit hash instea Done http://gerrit.cloudera.org:8080/#/c/18822/1//COMMIT_MSG@13 PS1, Line 13: Finally > nit: comma Done http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@550 PS1, Line 550: Macs > nit: Macs, and maybe mention Apple M chips for the first time in parenthese Done http://gerrit.cloudera.org:8080/#/c/18822/1/docs/installation.adoc@609 PS1, Line 609: .ARM Macs > is this only for ARM Macs? Shouldn't this be done on Intel Macs as well? Initially, while building on M1, the JWT build failed to find OpenSSL. JWT wasn't touched during the M1 upgrade, so I assumed that it is M1 specific, hence the ARM note. However I think it would be good to double check. I don't have an Intel Mac. Could someone, with an Intel machine please try to build Kudu master? Ideally it would work, but if the process fails on the thirdparty JWT step, I will move this note out of the ARM label. -- To view, visit http://gerrit.cloudera.org:8080/18822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02e5993979b88b525006344324e6b3be29aa869c Gerrit-Change-Number: 18822 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 08 Aug 2022 10:02:48 +0000 Gerrit-HasComments: Yes
