Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] KUDU-3389 support turning on/off auto rebalancer at runtime ...................................................................... Patch Set 31: Code-Review-1 (2 comments) Could you please address my comments on PS26? Most of them haven't been addressed. Thank you! http://gerrit.cloudera.org:8080/#/c/18679/26/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/18679/26/src/kudu/master/auto_rebalancer-test.cc@285 PS26, Line 285: // Make sure turn on/off auto-rebalancing is valid. > How about: Did you miss this one? http://gerrit.cloudera.org:8080/#/c/18679/26/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/26/src/kudu/master/auto_rebalancer.cc@194 PS26, Line 194: } > This looks a bit strange to me: there was a request to run the rebalancing Did you miss this one? -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 31 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 11 Aug 2022 20:24:59 +0000 Gerrit-HasComments: Yes
