Hello Marton Greber, Zoltan Chovan, Attila Bukor, Kudu Jenkins, Abhishek
Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18820
to look at the new patch set (#2).
Change subject: [macos] fix build on macOS (Catalina 10.15.7)
......................................................................
[macos] fix build on macOS (Catalina 10.15.7)
The change introduced with [1] broke build on my Intel-based macOS
Catalina 10.15.7. I guess it might be something related to the old
version of Xcode (12.4), but adding CMAKE_OSX_SYSROOT into the list
of libc++ include directories wasn't working as expected in my case.
This patch deduces the path to the libc++ include directory using the
output of 'clang++ --version' command, and I verified it works on macOS
BigSur 11.6.8 with Xcode 12.5 as expected.
I also added extra piece from Marton's patch [2] to tailor the approach
for Xcode of newer versions (13.0 and newer): with Xcode 13.0 and newer,
adding CMAKE_OSX_SYSROOT into the list of libc++ include directories
seems to work as intended. I also hope it works on M1-based macOS
as well when using Xcode of contemporary versions.
[1]
https://github.com/apache/kudu/commit/543e128d473f8f7836e605bba8cd6512fa918550
[2]
https://github.com/apache/kudu/commit/8ba59f6c8b8c706ca4c6cc49542e87274da674d1
Change-Id: Ib47f2d04cb87a3fc9c9a8b8c10c17d4f502c47c0
---
M src/kudu/codegen/CMakeLists.txt
1 file changed, 31 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/18820/2
--
To view, visit http://gerrit.cloudera.org:8080/18820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib47f2d04cb87a3fc9c9a8b8c10c17d4f502c47c0
Gerrit-Change-Number: 18820
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
