Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18820 )
Change subject: [macos] fix build on macOS (Xcode 12.4 and earlier) ...................................................................... [macos] fix build on macOS (Xcode 12.4 and earlier) The change introduced by [1] broke build on my macOS laptop with Xcode 12.4. This patch addresses the issue: as it turned out, starting with Xcode 12.5 the location of the libc++ headers changed, so it's necessary to use different approaches for different Xcode versions (for details, see the comment added in src/kudu/codegen/CMakeLists.txt). I verified the new approach works on my Intel-based laptop: * macOS Catalina 10.15.7 with Xcode 11.7, 12.4 * macOS BigSur 11.6.8 with Xcode 11.7, 12.4, 12.5, 13.2.1. [1] https://github.com/apache/kudu/commit/543e128d473f8f7836e605bba8cd6512fa918550 Change-Id: Ib47f2d04cb87a3fc9c9a8b8c10c17d4f502c47c0 Reviewed-on: http://gerrit.cloudera.org:8080/18820 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Attila Bukor <[email protected]> Tested-by: Attila Bukor <[email protected]> --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 41 insertions(+), 5 deletions(-) Approvals: Alexey Serbin: Verified Attila Bukor: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib47f2d04cb87a3fc9c9a8b8c10c17d4f502c47c0 Gerrit-Change-Number: 18820 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
