Marton Greber has posted comments on this change. (
http://gerrit.cloudera.org:8080/18820 )
Change subject: [macos] fix build on macOS (Catalina 10.15.7)
......................................................................
Patch Set 1:
I did run some tests on M1 mac. (Context: ARM symbols are included with Xcode
version 12.2)
Xcode 12.2 - 12.4 (inclusive): the present patch is required. Kudu builds and
runs.
Xcode 12.5 - 13.2 (inclusive): the present patch fails. set(IR_CXX_SYSTEM
"${CMAKE_OSX_SYSROOT}") is required. After modification, Kudu builds and runs.
Xcode 13.3 and above is not yet supported: KUDU-3391
Possible fix:
Xcode 12.5 contains clang-1205.0.22.9. (https://gist.github.com/yamaya/2924292)
If the compiler version is greater than 12.0.5, use CMAKE_OSX_SYSROOT for
IR_CXX_SYSTEM, else use the logic shown by the present patch.
--
To view, visit http://gerrit.cloudera.org:8080/18820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47f2d04cb87a3fc9c9a8b8c10c17d4f502c47c0
Gerrit-Change-Number: 18820
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Tue, 16 Aug 2022 19:10:17 +0000
Gerrit-HasComments: No
