Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18834 )
Change subject: [tool] Add output format for 'table list' CLI tool. ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/18834/7//COMMIT_MSG Commit Message: PS7: Can we have a sample run of the command in json format on a table with 2-3 tablets? http://gerrit.cloudera.org:8080/#/c/18834/7//COMMIT_MSG@14 PS7, Line 14: `kudu table list --list_table_output=<table|json|json_compact> <table_name> <master_addresses> [-negotiation_timeout_ms=<ms>] [-timeout_ms=<ms>]` Order of the arguments in incorrect. Please refer below: https://kudu.apache.org/docs/command_line_tools_reference.html#table-list http://gerrit.cloudera.org:8080/#/c/18834/7/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18834/7/src/kudu/tools/tool_action_table.cc@312 PS7, Line 312: table_info_pb->set_name(tname) This can probably be moved out of the if else blocks. -- To view, visit http://gerrit.cloudera.org:8080/18834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aaec73e18872fc93646e9c0ea675b578b0702f0 Gerrit-Change-Number: 18834 Gerrit-PatchSet: 7 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Aug 2022 02:39:41 +0000 Gerrit-HasComments: Yes
