Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18834 )
Change subject: [tool] Add output format for 'table list' CLI tool. ...................................................................... Patch Set 8: Code-Review+1 (3 comments) Overall looks good to me, just a few nits. http://gerrit.cloudera.org:8080/#/c/18834/8/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18834/8/src/kudu/tools/kudu-tool-test.cc@3287 PS8, Line 3287: lines[2] Please add an ASSERT on the size of the 'lines' array (to be at least of size 3, so accessing lines[2] isn't to lead to anything unexpected) http://gerrit.cloudera.org:8080/#/c/18834/8/src/kudu/tools/kudu-tool-test.cc@3287 PS8, Line 3287: string auto_table_name = lines[2].erase(0,lines[2].find_first_not_of(' ')); nit: add a space after comma http://gerrit.cloudera.org:8080/#/c/18834/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18834/1/src/kudu/tools/tool_action_table.cc@262 PS1, Line 262: replica > We do need to format the output in actual use. In order not to break our us Yes, you are right: if doing that, it's better to do it in a separate patch to change that for all the tools. That's a good point. -- To view, visit http://gerrit.cloudera.org:8080/18834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aaec73e18872fc93646e9c0ea675b578b0702f0 Gerrit-Change-Number: 18834 Gerrit-PatchSet: 8 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 20 Aug 2022 17:06:39 +0000 Gerrit-HasComments: Yes
